[Bug] fix wrong null flag#10883
Merged
dataroaring merged 3 commits intoapache:masterfrom Jul 16, 2022
Merged
Conversation
Gabriel39
force-pushed
the
fix_conpaction
branch
2 times, most recently
from
2e88857 to
762fb56
Compare
Gabriel39
force-pushed
the
fix_conpaction
branch
from
762fb56 to
96c31ea
Compare
Contributor
|
Why not adjust null_map pos inside set_source_column? |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
@cambyzju If we do so, inside |
dataroaring
approved these changes
Jul 16, 2022
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
5 tasks
yiguolei
pushed a commit
that referenced
this pull request
Apr 3, 2023
The offset of _nullmap and _value are inconsistent in OlapDataConvertor, so the obtained null flag is incorrect when calling get_ data_ at function. When the key column or sequence column has null values, the encoding of the short key index or primary key index may be wrong. This was introduced by #10883 #10925.
zhannngchen
pushed a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Apr 3, 2023
The offset of _nullmap and _value are inconsistent in OlapDataConvertor, so the obtained null flag is incorrect when calling get_ data_ at function. When the key column or sequence column has null values, the encoding of the short key index or primary key index may be wrong. This was introduced by apache#10883 apache#10925.
zhannngchen
pushed a commit
that referenced
this pull request
Apr 3, 2023
The offset of _nullmap and _value are inconsistent in OlapDataConvertor, so the obtained null flag is incorrect when calling get_ data_ at function. When the key column or sequence column has null values, the encoding of the short key index or primary key index may be wrong. This was introduced by #10883 #10925.
zhannngchen
pushed a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Apr 3, 2023
The offset of _nullmap and _value are inconsistent in OlapDataConvertor, so the obtained null flag is incorrect when calling get_ data_ at function. When the key column or sequence column has null values, the encoding of the short key index or primary key index may be wrong. This was introduced by apache#10883 apache#10925.
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
The offset of _nullmap and _value are inconsistent in OlapDataConvertor, so the obtained null flag is incorrect when calling get_ data_ at function. When the key column or sequence column has null values, the encoding of the short key index or primary key index may be wrong. This was introduced by apache#10883 apache#10925.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
The offset of _nullmap and _value are inconsistent in OlapDataConvertor, so the obtained null flag is incorrect when calling get_ data_ at function. When the key column or sequence column has null values, the encoding of the short key index or primary key index may be wrong. This was introduced by apache#10883 apache#10925.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...